Open
Conversation
beeequeue
requested changes
Feb 25, 2026
Owner
beeequeue
left a comment
beeequeue
left a comment
There was a problem hiding this comment.
while i do agree with this in a sense of proper code hygiene, im also not sure if removing it is a good idea since it would break backwards compatibility for anyone expecting the field to exist.
but is there actually anyone that uses the notify-moe fields? :^)
maybe it's just better to keep the field and always return null for it?
Contributor
Author
|
That is a fair assessment, one I also considered. Both the "does anyone use this?" and "shouldn't code always be safe and account for both field nullability and absence?" angles. Your call, I promise I won't be offended if you decide to keep the field and close the PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separating from and per request on #906
What changed:
Removed
notify-moefrom the response since it was removed upstream both manami (manami-project/manami#1066) and consequently from Fribb's anime-list (Fribb/anime-lists#23 (comment)) since Fribb uses manami's anime-offline-database to generate the list we use to populate the database